Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust find in page modal style #7087

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 28, 2024

image
image

Copy link

graphite-app bot commented May 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review May 28, 2024 04:51
Copy link
Member Author

JimmFly commented May 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 28, 2024

@JimmFly JimmFly requested a review from pengx17 May 28, 2024 04:54
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.92%. Comparing base (2ca77d9) to head (9d296c4).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           xp/05-28-refactor_find_in_page    #7087      +/-   ##
==================================================================
- Coverage                           66.98%   66.92%   -0.07%     
==================================================================
  Files                                 592      592              
  Lines                               28950    28950              
  Branches                             2616     2615       -1     
==================================================================
- Hits                                19392    19374      -18     
- Misses                               9285     9303      +18     
  Partials                              273      273              
Flag Coverage Δ
server-test 77.56% <ø> (-0.09%) ⬇️
unittest 39.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly requested a review from zanwei May 28, 2024 05:00
@JimmFly JimmFly force-pushed the jimmfly/0528/style branch from f2d3096 to 5cbd041 Compare May 28, 2024 05:14
Copy link

graphite-app bot commented May 28, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/05-28-refactor_find_in_page branch from 99d1948 to 2ca77d9 Compare May 28, 2024 06:21
@pengx17 pengx17 force-pushed the jimmfly/0528/style branch from 5cbd041 to 9d296c4 Compare May 28, 2024 06:21
@pengx17 pengx17 changed the base branch from xp/05-28-refactor_find_in_page to canary May 28, 2024 06:31
@graphite-app graphite-app bot merged commit 9d296c4 into canary May 28, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0528/style branch May 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants